Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete extra "Return True" #48089

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Delete extra "Return True" #48089

merged 1 commit into from
Sep 28, 2020

Conversation

Youssef1313
Copy link
Member

Introduced in #712

@Youssef1313 Youssef1313 requested a review from a team as a code owner September 27, 2020 00:29
@alrz
Copy link
Member

alrz commented Sep 27, 2020

wait, we dont warn on unreachable code?

@Youssef1313
Copy link
Member Author

@alrz I was surprised too, but looks like the case with VB.

@CyrusNajmabadi
Copy link
Member

VB doens't have the concept. I believe there's an issue tracking that we would take a PR here to add such a thing as an analyzer.

AlekseyTs
AlekseyTs approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@333fred 333fred merged commit a09cdaa into dotnet:master Sep 28, 2020
@ghost ghost added this to the Next milestone Sep 28, 2020
@333fred
Copy link
Member

333fred commented Sep 28, 2020

Thanks Youseff!

333fred added a commit that referenced this pull request Sep 28, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merges/master-to-…
858ff35 
…features/interpolated-string-constants

* upstream/master: (1950 commits)
  Delete extra "Return True" (#48089)
  Remove unused param
  Extract local
  Update help service to account for all `TypeDeclarationSyntax` (namespace+record+struct) as partial type (#48095)
  Don't offer to remove as cast from using statements or declarations (#48110)
  Cleaner solution
  Update tests
  Don't offer to remove necessary native integer casts
  Fix xml attribute name classification
  Use switch expressions.
  Add test for IAsyncEnumerable<string>
  Fix tests
  Add tests
  Update CSharpTypeInferenceService.TypeInferrer.cs
  Fix failure to dispose RemoteWorkspace in tests
  [master] Update dependencies from dotnet/roslyn (#48072)
  Simplify common calls to Parallel.For with a RoslynParallel.For helper
  Fallback to IEnumerable<> if IAsyncEnumerable<> not found
  Fix cancellation handling in Parallel.For
  Update InferTypeInForEachStatement to respect await foreach
  ...
@Youssef1313 Youssef1313 deleted the patch-17 branch September 28, 2020 20:30
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jmarolf jmarolf jmarolf approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.9.P1
Development

Successfully merging this pull request may close these issues.
7 participants
@Youssef1313 @alrz @CyrusNajmabadi @333fred @jmarolf @AlekseyTs @Cosifne